Open
Conversation
fa03b2e to
e7f4e9f
Compare
|
https://github.com/tsoding/emoteJAM/pull/90/files#r1718035530 this is a much better solution. consider doing something like this instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type definitions for the
Tagtype with interoperability withHTMLElementand types derived from it.It introduces a
IntrinsicElementsinterface which is a map of element names corresponding with their correspondingHTMLElementsubtype. This is used as a way to provide type information inferred from the element name.It can be further extended with minimum effort;
Since
tagnow inters the type from element name ("form"), it returns the correct typeTag<HTMLFormElement>and no longer requires explicit return types or casting.There is also partial support for augmenting
Tagelements with custom methods ending with a dollar-sign ("$"). Although these are not type-safe and has to be managed by the user manually, since there is not an easy way to infer those types.It does so by utilizing template literals index signature, as introduced in TypeScript 4.4. Therefore this PR also upgrades TypeScript to the latest version (4.5).