Skip to content

Component details overlay#166

Merged
tsg21 merged 1 commit into
mainfrom
components-details
May 17, 2026
Merged

Component details overlay#166
tsg21 merged 1 commit into
mainfrom
components-details

Conversation

@tsg21

@tsg21 tsg21 commented May 16, 2026

Copy link
Copy Markdown
Owner

No description provided.

@tsg21

tsg21 commented May 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cf7083ef8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

readOnly={readOnly}
/>
</div>
{!readOnly && (

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Collapse read-only fitter to one column

When readOnly is true this change stops rendering the palette, but the parent grid still uses xl:grid-cols-[minmax(0,1fr)_24rem], so at extra-large breakpoints the right 24rem track becomes empty and the hull/details area is unnecessarily compressed. This regresses the design-inspection view (DragAndDropFitter in read-only mode) by wasting horizontal space; conditionally switching to a single-column grid (or keeping a right-column placeholder) would avoid the layout gap.

Useful? React with 👍 / 👎.

@tsg21 tsg21 merged commit 13a1538 into main May 17, 2026
1 check passed
@tsg21 tsg21 deleted the components-details branch May 17, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant