Skip to content

Fixes #30 /claim #30#164

Open
theherrovn-sys wants to merge 1 commit into
tscircuit:mainfrom
theherrovn-sys:main
Open

Fixes #30 /claim #30#164
theherrovn-sys wants to merge 1 commit into
tscircuit:mainfrom
theherrovn-sys:main

Conversation

@theherrovn-sys
Copy link
Copy Markdown

@theherrovn-sys theherrovn-sys commented May 31, 2026

Fixes #30 /claim #30

  • Changed withResponseObjectCheck middleware to throw RawJsonResponseError (extends BadRequestError, an HttpException) instead of plain Error
  • This ensures the error message "Use ctx.json({...}) instead of returning an object directly" properly propagates through the middleware chain
  • Updated withUnhandledExceptionHandling to return proper JSON error responses for HttpException instances instead of blank 500 responses
  • All 185 tests pass, including do-not-allow-raw-json and invalid-response-error tests

@algora-pbc algora-pbc Bot mentioned this pull request May 31, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seveibar seveibar Awaiting requested review from seveibar seveibar is a code owner

@ShiboSoftwareDev ShiboSoftwareDev Awaiting requested review from ShiboSoftwareDev ShiboSoftwareDev is a code owner

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When a user returns return { ... } from a route instead of return ctx.json({ ... }), throw an error telling them to use ctx.json

1 participant

@theherrovn-sys