fix(middleware): propagate return plain object error message instead of masking (#30)#160
Open
Heyzerohey wants to merge 3 commits into
Open
fix(middleware): propagate return plain object error message instead of masking (#30)#160Heyzerohey wants to merge 3 commits into
Heyzerohey wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
This PR fixes the issue where returning a plain object
return { ... }from a route instead ofreturn ctx.json({ ... })was masked as a generic500 Internal server errorin production/default exception handling.Changes
ResponseObjectNotAllowedError: Added a subclass ofWinterSpecMiddlewareErrorinsrc/middleware/http-exceptions.tscontaining the helpful error message"Use ctx.json({...}) instead of returning an object directly."with a status of500.withResponseObjectCheck: ThrowResponseObjectNotAllowedErrorinsrc/middleware/with-response-object-check.tsinstead of throwing a genericError.tests/middleware/with-response-object-check.test.tsverifying that returning a plain object propagates the correct error message through default exception handling./claim #30