Add SameNetTraceMergeSolver to merge close parallel trace segments#135
Open
Nithinfgs wants to merge 4 commits intotscircuit:mainfrom
Open
Add SameNetTraceMergeSolver to merge close parallel trace segments#135Nithinfgs wants to merge 4 commits intotscircuit:mainfrom
Nithinfgs wants to merge 4 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Hey @seveibar, I’ve added the SameNetTraceMergeSolver and verified all tests pass. Could you take a look and check this out for the bounty? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #29
Implementation Summary:
This PR introduces a new pipeline phase called
SameNetTraceMergeSolverthat merges trace segments belonging to the same net when they are sufficiently close together. The goal is to eliminate redundant parallel traces and produce a cleaner schematic trace output.The solver checks trace endpoints and merges segments when the geometric distance between them is below a small threshold. This ensures traces that should logically form a continuous connection are represented as a single merged segment.
Verification:
• Implemented the solver
SameNetTraceMergeSolverto detect and merge close same-net trace segments.• Verified the implementation by running the full test suite (
bun test).• All existing tests pass successfully after adding the solver.
Integration:
The new solver is designed to run as part of the schematic trace solving pipeline and processes trace segments before the final output stage, ensuring that redundant segments are merged before further processing.