feat: specialized linear layout for decoupling capacitor partitions#48
Open
themachinehf wants to merge 1 commit intotscircuit:mainfrom
Open
feat: specialized linear layout for decoupling capacitor partitions#48themachinehf wants to merge 1 commit intotscircuit:mainfrom
themachinehf wants to merge 1 commit intotscircuit:mainfrom
Conversation
Arranges decoupling capacitors in a clean horizontal row instead of using the general-purpose packer which produces messy layouts. For decoupling_caps partitions, capacitors are now: - Sorted by chip ID (deterministic ordering) - Placed in a single horizontal row centered at x=0 - Use consistent spacing (decouplingCapsGap or chipGap) - Have 0 rotation (capacitors are symmetric) Adds test case to verify horizontal linear layout behavior.
|
@themachinehf is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #15
Summary
Replaces the generic PackSolver2 with a dedicated horizontal row layout for partitions of type `decoupling_caps`, matching the "acceptable solution" image posted by @seveibar.
Before / After
Before (PackSolver2): capacitors cluster in a chaotic pile with irregular spacing
After (this PR): capacitors are arranged in a clean horizontal row, centered at origin, with configurable gap:
```
[C1] [C2] [C3] [C4]
← centered at x=0 →
```
Implementation
Modified `SingleInnerPartitionPackingSolver.createLayoutFromPackingResult()`:
Files Changed
Testing
```bash
bun test tests/DecouplingCapLayout/DecouplingCapLayout01.test.ts
```
All existing tests pass (18 pass, 1 pre-existing error unrelated to this change).