Fix : decoupling capacitor partition to include main chip#42
Open
Prashant27-07 wants to merge 5 commits intotscircuit:mainfrom
Open
Fix : decoupling capacitor partition to include main chip#42Prashant27-07 wants to merge 5 commits intotscircuit:mainfrom
Prashant27-07 wants to merge 5 commits intotscircuit:mainfrom
Conversation
|
@Prashant27-07 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I ran the formatter and pushed the formatting commit. The CI failure seems to come from a dependency issue:
The error appears unrelated to the changes in ChipPartitionsSolver. Please let me know if you'd like me to investigate further or adjust the solver logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the decoupling capacitor partition logic in ChipPartitionsSolver.
Previously, partitions created for decoupling capacitor groups excluded the main chip.
This caused the partition to miss the chip that the capacitors were actually associated with.
This change ensures that the main chip is included in the partition together with the decoupling capacitors.
Closes #15