Skip to content

feat: add overlap resolution phase after partition packing#39

Open
yuliuyi717-ux wants to merge 1 commit intotscircuit:mainfrom
yuliuyi717-ux:codex/overlap-resolution-phase-12
Open

feat: add overlap resolution phase after partition packing#39
yuliuyi717-ux wants to merge 1 commit intotscircuit:mainfrom
yuliuyi717-ux:codex/overlap-resolution-phase-12

Conversation

@yuliuyi717-ux
Copy link
Copy Markdown

Summary

  • add OverlapResolutionSolver as a final layout phase after PartitionPackingSolver
  • resolve residual chip overlaps with deterministic pairwise displacement and chip-gap-aware bounds
  • return overlap-resolved placement in getOutputLayout()
  • include dedicated tests for solver behavior and pipeline integration

Why

Issue #12 asks for improved layout quality for the repro in #11 and suggests a new phase/technique. This adds a focused post-pack cleanup phase that removes residual overlaps without changing upstream partition logic.

TDD

  • RED: added failing test file for missing solver + missing final phase
  • GREEN: implemented solver + integrated phase into pipeline

Validation

bun test tests/OverlapResolutionSolver/overlap-resolution-solver.test.ts
bun test tests/LayoutPipelineSolver/LayoutPipelineSolver04.test.ts tests/PartitionPackingSolver/PartitionPackingSolver01.test.ts
bunx biome check lib/solvers/OverlapResolutionSolver/OverlapResolutionSolver.ts lib/solvers/LayoutPipelineSolver/LayoutPipelineSolver.ts tests/OverlapResolutionSolver/overlap-resolution-solver.test.ts

/claim #12

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 2, 2026

@yuliuyi717-ux is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

@yuliuyi717-ux
Copy link
Copy Markdown
Author

Hi! The Vercel bot says the deployment needs authorization.
Could someone from the team approve the deploy?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant