feat: Specialized linear layout for decoupling capacitors#36
Open
769066112-ops wants to merge 1 commit intotscircuit:mainfrom
Open
feat: Specialized linear layout for decoupling capacitors#36769066112-ops wants to merge 1 commit intotscircuit:mainfrom
769066112-ops wants to merge 1 commit intotscircuit:mainfrom
Conversation
…scircuit#15) When SingleInnerPartitionPackingSolver encounters a partition with partitionType === 'decoupling_caps', it bypasses PackSolver2 and arranges caps in a clean horizontal row instead. - Caps sorted by chipId for deterministic ordering - Evenly spaced using decouplingCapsGap (falls back to chipGap) - Centered at origin - Zero impact on non-decoupling partitions Adds 3 tests covering linear layout, custom gap, and non-decoupling fallback.
|
@769066112-ops is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a specialized layout algorithm for decoupling capacitor partitions as described in #15.
When
SingleInnerPartitionPackingSolverencounters a partition withpartitionType === "decoupling_caps", it bypasses the genericPackSolver2packing algorithm and arranges the capacitors in a clean horizontal row instead.Changes
lib/solvers/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.ts_step()for decoupling cap partitionscreateLinearDecouplingCapLayout()method:decouplingCapsGap(falls back tochipGap)tests/DecouplingCapsLinearLayout.test.ts(new)decouplingCapsGapsupport, non-decoupling partition fallback to PackSolver2Impact
Zero impact on non-decoupling partitions — the early return only triggers when
partitionType === "decoupling_caps"./claim #15
I have read the CLA Document and I hereby sign the CLA