feat: Specialized packing strategy for decoupling capacitors#28
Open
natinew77-creator wants to merge 12 commits intotscircuit:mainfrom
Open
feat: Specialized packing strategy for decoupling capacitors#28natinew77-creator wants to merge 12 commits intotscircuit:mainfrom
natinew77-creator wants to merge 12 commits intotscircuit:mainfrom
Conversation
|
@natinew77-creator is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Ready for review! If there is any feedback, I am happy to address it. |
seveibar
requested changes
Jan 9, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
where is the evidence this works?
Author
Author
|
Hi @seveibar and @techmannih, I've updated the PR with the requested visual evidence and addressed the feedback regarding console logs and test assertions. |
seveibar
requested changes
Jan 11, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
needs visual snapshot testing (i.e. svgs, as is our standard practice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

/claim #15
Implements a specialized packing strategy for decoupling capacitors to ensure neat, linear layouts.
Changes
packDecouplingCapsmethod toSingleInnerPartitionPackingSolver.Verification
Added
tests/DecouplingCapacitorPacking.test.tswhich verifies:The test output confirms the linear arrangement: