Open
Conversation
Owner
|
Really appreciate your contribution! I haven't had time to test this yet, and might not for a while, but happy to merge this into master if you feel confident? |
Author
|
It would be better if someone take a look at the changes and did at least one old arch / new arch test to make sure everything is working |
|
Thanks for the great library! Is there a possibility to get this merged? We'd like to keep using this library also with the New Arch. |
Owner
|
Yes I think it's about time! I will have a look in the next several weeks, but also happy to accept an updated version of this PR that is mergable. |
|
@tschoffelen #146 This seems to be the more recent PR to work from? Would love to use this library but am unfortunately on new arch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for both new and old architecture.
This change is Android only, since only Android requires native dev for opening mail through an intent.
Suggestions / Discussions
EmailPackage->RNEmailPackage,EmailImpl->RNEmailImpl,Email.java->RNEmail.java)