fix: handle RecipientPreference return type from updatePreferences mutation (SUP-561)#681
Open
fix: handle RecipientPreference return type from updatePreferences mutation (SUP-561)#681
Conversation
…tation (SUP-561) The updatePreferences mutation now returns a RecipientPreference object instead of Void. Updated the SDK to select return fields, use server response data, and propagate GraphQL errors. Made-with: Cursor
5089384 to
681642b
Compare
The backend returns RecipientPreference from the existing updatePreferences mutation, no need for a V2 endpoint. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updatePreferencesmutation now returns aRecipientPreferenceobject instead ofVoid(backend PR #9335)templateId,status,hasCustomRouting,routingPreferences,digestSchedule)ERRORreducer case anderrorfield onPreferenceStateChanges
packages/client-graphql/src/preferences.ts— Updated mutation query to selectRecipientPreferencefields; return server response data; throw on GraphQL errorspackages/react-hooks/src/preferences/reducer.ts— Clear error on success; handleUPDATE_RECIPIENT_PREFERENCES/ERRORactionpackages/react-hooks/src/preferences/types.ts— Addederror?: ErrortoPreferenceStateTest plan
Ran 23 integration tests against dev shared — all passing.
RecipientPreferenceobject (notnull)digestScheduleupdate round-tripdigestSchedulewithaccountId(SUP-561 customer scenario)hasCustomRouting+routingPreferences)Made with Cursor