Encapsulate utility functions into CloudRemoval class for better code organization#2
Draft
Copilot wants to merge 2 commits into
Draft
Encapsulate utility functions into CloudRemoval class for better code organization#2Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…nization Co-authored-by: try-agaaain <52828870+try-agaaain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 这个项目中,我希望将cloud_removal.py的功能封装为类,以便逻辑更加清晰
Encapsulate utility functions into CloudRemoval class for better code organization
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
cloud_removal.pymodule to improve code organization by moving standalone utility functions into theCloudRemovalclass as static methods.Problem
The original code had three utility functions defined as standalone functions outside the class:
set_seed(seed=4096)- for setting random seeds for reproducibilitythres_21(L, tau, M, N, B)- for threshold computation in the optimization algorithmdeal_real_data_for_gdd(Noisy)- for preprocessing data for the GDD networkThis created a mixed code structure where cloud removal functionality was split between the
CloudRemovalclass and global utility functions, making the codebase less organized and harder to maintain.Solution
Moved all three utility functions into the
CloudRemovalclass as static methods:Updated all internal function calls to use the class methods:
set_seed()→CloudRemoval.set_seed()thres_21(L, tau, M, N, B)→CloudRemoval.thres_21(L, tau, M, N, B)Benefits
CloudRemovalclassmain.pycontinues to work unchangedTesting
The refactoring achieves the goal of making the cloud removal logic clearer and more organized while maintaining full backward compatibility.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.