Skip to content

chore: give tn-node healthcheck room for long maintenance#1379

Merged
MicBun merged 1 commit into
mainfrom
tnNodeHealthcheckStartPeriod
May 13, 2026
Merged

chore: give tn-node healthcheck room for long maintenance#1379
MicBun merged 1 commit into
mainfrom
tnNodeHealthcheckStartPeriod

Conversation

@MicBun
Copy link
Copy Markdown
Contributor

@MicBun MicBun commented May 13, 2026

resolves: https://github.com/truflation/website/issues/3872

Summary by CodeRabbit

  • Chores
    • Extended database service startup grace period to improve initialization reliability during container startup.

Review Change Stack

@MicBun MicBun requested a review from pr-time-tracker May 13, 2026 11:24
@MicBun MicBun self-assigned this May 13, 2026
@holdex
Copy link
Copy Markdown

holdex Bot commented May 13, 2026

Time Submission Status

Member Status Time Action Last Update
MicBun ✅ Submitted 1h Update time May 13, 2026, 11:25 AM

You can submit time with the command. Example:

@holdex pr submit-time 15m

See available commands to help comply with our Guidelines.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 90fb5a99-ad83-4647-ba1d-95b351cb6f9f

📥 Commits

Reviewing files that changed from the base of the PR and between 46e3aac and a9b37d3.

📒 Files selected for processing (1)
  • compose.yaml

📝 Walkthrough

Walkthrough

The PR adds a 5-minute start period to the tn-db service healthcheck in compose.yaml, allowing the database container additional initialization time before health checks begin evaluating its status.

Changes

tn-db Healthcheck Configuration

Layer / File(s) Summary
tn-db healthcheck start period
compose.yaml
The tn-db service healthcheck is updated with start_period: 5m, delaying health evaluation to allow database initialization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • trufnetwork/node#1165: Adds the initial healthcheck block to the tn-db service; this PR extends that configuration with a start period grace window.

Poem

A database needs a moment to wake,
Five minutes to settle, for goodness sake! 🐰
No rushing the checks, let it breathe and restore,
Now startup runs smoothly, just like before. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'tn-node healthcheck' but the actual change is to the 'tn-db' service healthcheck in compose.yaml, creating a mismatch between the stated and actual changes. Update the title to accurately reflect that the change is to the tn-db service healthcheck, e.g., 'chore: give tn-db healthcheck room for long maintenance'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tnNodeHealthcheckStartPeriod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MicBun
Copy link
Copy Markdown
Contributor Author

MicBun commented May 13, 2026

@holdex pr submit-time 1h

@MicBun MicBun merged commit a178a72 into main May 13, 2026
8 checks passed
@MicBun MicBun deleted the tnNodeHealthcheckStartPeriod branch May 13, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant