Exit with code EX_DATAERR if --list-different and formatting needed#36
Open
dignite wants to merge 4 commits intotrixnz:masterfrom
Open
Exit with code EX_DATAERR if --list-different and formatting needed#36dignite wants to merge 4 commits intotrixnz:masterfrom
dignite wants to merge 4 commits intotrixnz:masterfrom
Conversation
added 4 commits
October 16, 2018 20:42
Author
|
Ping @trixnz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In order to ensure
lua-fmthas been runWe want to be able to run
lua-fmt --list-differentthat exits with exit code above 0 if formatting was neededHow
Exit code EX_DATAERR (65) selected after consulting sysexits(3)
Same flag and behavior as in prettier.
Tests on Windows 10
I had a failing test locally even before starting and was not able to resolve it.