Skip to content

chore: restore mav updates#348

Merged
AskewParity merged 2 commits intomainfrom
fix/mavlink-data
Mar 5, 2026
Merged

chore: restore mav updates#348
AskewParity merged 2 commits intomainfrom
fix/mavlink-data

Conversation

@AskewParity
Copy link
Contributor

Soooooooo, apparently, our mav implementation doesn't impliment our own specificaiton

  • add subscribe for heading
  • restore subscribe for yaw, pitch, roll (I don't know why this was commented out in the first place)

Nothing has been tested...

Copy link
Contributor

@miyatakazuya miyatakazuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but do we ever use IMU data in the obcpp controls? Same with heading.

@AskewParity
Copy link
Contributor Author

AskewParity commented Feb 27, 2026

Yes, read the next PR (oops, I forgot to undraft it). I don't think we use IMU data, would you like me to delete it?

@miyatakazuya
Copy link
Contributor

@kimichenn Can you verify this PR works on SITL? Having some issues wit my ubuntu env atm.
You can probably modify tests/integration/mavlink_client.cpp to output heading yaw pitch roll to test function.

Copy link
Contributor

@kimichenn kimichenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Everything looks okish from sitl, though the pitch is kinda sketch, but that can just be us being in quadcopter instead of quadplane. We could test it on Lek's quad, but mav is too nasty to work with. Let's just hope nothing breaks when we do fly.

@AskewParity AskewParity merged commit 6dfd6ae into main Mar 5, 2026
2 checks passed
@kimichenn kimichenn deleted the fix/mavlink-data branch March 5, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants