Open
Conversation
miyatakazuya
requested changes
Mar 4, 2026
Contributor
miyatakazuya
left a comment
There was a problem hiding this comment.
Big thanks for fixing this. I've noticed some extraneous comments + potential bug on the path generation timeout. I didn't SITL test it yet, but should be addressed.
Also looking at the TODOs on the PR, I think the need to add a "path generation" tick is urgent. As is, if the path generation does time out and return nullptr, the isMissionFinished() may still be true because a new mission isn't uploaded yet, which would cause the lap count to decrement without the path generation succeeding.
src/ticks/fly_waypoints.cpp
Outdated
| return nullptr; | ||
| } | ||
|
|
||
| state->config.pathing.laps--; |
Contributor
There was a problem hiding this comment.
I think its bad practice to modify anything from the config period(should just be const tbh). I think the current_lap should be mutable only via Mission_state
…, chore: made config const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MUST MERGE MAV UPDATES BEFORE THIS
closes #341
staticto get current plane locationTesting
path_planning,coverage_pathing,airdrop_approach<-- terrible naming scheme)TODO