fix: https://github.com/triton-inference-server/server/issues/8537#435
Open
aleksn7 wants to merge 1 commit into
Open
fix: https://github.com/triton-inference-server/server/issues/8537#435aleksn7 wants to merge 1 commit into
aleksn7 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution. @aleksn7, have you signed a CLA? If not, please see Contributing / CLA. |
There was a problem hiding this comment.
Pull request overview
This PR addresses a race condition in the Python backend stub’s async coroutine handling for decoupled execution, ensuring background futures are tracked before their completion callback can run.
Changes:
- Reorders
background_futures_.add()to occur beforeadd_done_callback()inStub::RunCoroutine. - Adds an in-code comment referencing the upstream issue for context.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
943
to
945
| py_future.attr("add_done_callback")( | ||
| py::module_::import("c_python_backend_utils") | ||
| .attr("async_event_future_done_callback")); |
Author
Hello! I've just signed the CLA |
Contributor
|
Pipeline ID: 51138619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the race between the done callback
async_event_future_done_callbackand thebackground_futures_.attr("add")Pull request for issue described here:
triton-inference-server/server#8537