Support building with MinGW on Linux + CMake#88
Open
vs49688 wants to merge 20 commits into
Open
Conversation
vs49688
force-pushed
the
cmake
branch
5 times, most recently
from
034166f to
16d6748
Compare
We don't need special handling for the .rc's anymore.
vs49688
force-pushed
the
cmake
branch
3 times, most recently
from
1844923 to
a7a7b96
Compare
MSVC and windres have different behaviours. Just duplicate the damned string.
:: isn't a token, the ## isn't needed. Fixes compilation on MinGW.
They're function templates, it's unnecessary. And it shuts MSVC up.
Fixes GCC 15 complaining.
I'm not sure I like this.
Author
|
Ready, tested & working. Both on MinGW cross builds, and native MSVC builds. Generated MinGW Release ZIP: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was easier than anticipated, and it works.
Tested on:
i686-w64-mingw32-gcc (GCC) 14.3.0+ CMake 4.To build on Linux
Install MinGW w64 i686, you should have
i686-w64-mingw32-gccandi686-w64-mingw32-g++in your PATH.or
To build on Windows
Install the MSVC 2022 Build Tools (or VS itself)
Open
build/windows/OpenLRR.sln