Skip to content

Perform XPath lookups on private XML node copy to maintain thread safety #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwetrifork merged 1 commit into from
Jun 11, 2026
Merged

Perform XPath lookups on private XML node copy to maintain thread safety #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Extensions/XEP-0136/CoreDataStorage/XMPPMessageArchivingCoreDataStorage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,12 @@ - (XMPPMessageArchiving_Message_CoreDataObject *)composingMessageWithJid:(XMPPJI

- (BOOL)messageContainsRelevantContent:(XMPPMessage *)message
{
// The underlying XML processing is thread safe for read access only: https://github.com/robbiehanson/KissXML/wiki/MemoryManagementThreadSafety
// XPath-based node lookup has to be performed on a copy as it requires temporary document assignment and therefore is not a strictly read operation
XMPPMessage *messageCopy = [message copy];
for (NSString *XPath in self.relevantContentXPaths) {
NSError *error;
NSArray *nodes = [message nodesForXPath:XPath error:&error];
NSArray *nodes = [messageCopy nodesForXPath:XPath error:&error];
if (!nodes) {
XMPPLogError(@"%@: %@ - Error querying XPath (%@): %@", THIS_FILE, THIS_METHOD, XPath, error);
continue;
Expand Down