feat: add new color token and font customization#276
Closed
ClaraTschamon wants to merge 1 commit intomainfrom
Closed
feat: add new color token and font customization#276ClaraTschamon wants to merge 1 commit intomainfrom
ClaraTschamon wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
ClaraTschamon
force-pushed
the
ct/add-font-and-color-customizations
branch
from
1fca289 to
0c96906
Compare
ClaraTschamon
requested review from
SchnozzleCat,
antesberger,
lukasbals and
rschiffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really know how to handle Tobis requirements correctly because our Boemly is not adapted to the new Brand Guidelines...
He requested the Heading in one strapi-slices to be "forestgreen"... which is defined in the new brand guideline but not in boemly yet.
Also he requested "big number" to be in another font... so I need to add an option to display big fonts in another color...
Named it metric because of this documentation:
https://atlassian.design/foundations/typography#metric
How it works:
I can pass the font which should be used for "metric" to the SliceRenderer.
Need to define the
fontFamily="metric"where I have big numbers: