Fix Swift build cannot find src/scanner.c.#372
Open
thiezn wants to merge 1 commit intotree-sitter:masterfrom
Open
Fix Swift build cannot find src/scanner.c.#372thiezn wants to merge 1 commit intotree-sitter:masterfrom
thiezn wants to merge 1 commit intotree-sitter:masterfrom
Conversation
missing src/scanner.c caused compile issues within Xcode.
example output:
ld: warning: Could not parse or use implicit file '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/SwiftUICore.framework/Versions/A/SwiftUICore.tbd': cannot link directly with 'SwiftUICore' because product being built is not an allowed client of it
Undefined symbols for architecture arm64:
"_tree_sitter_css_external_scanner_create", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_deserialize", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_destroy", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_scan", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_serialize", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_javascript_external_scanner_create", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_deserialize", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_destroy", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_scan", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_serialize", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
|
The same as tree-sitter/tree-sitter-css#90. I’m encountering the same issue, and I’ve confirmed that this PR resolves it in my project as well. I hope this PR will be merges. |
Member
|
How does this fix anything? The logic is not any different, which means however you've setup the project is messing with scanner detection. The point of the code is to have generated bindings that work for grammars with and without scanners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing src/scanner.c caused compile issues within Xcode.
Updated package.swift to follow the working tree-sitter-html Package.swift format.
Example output:
ld: warning: Could not parse or use implicit file '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/SwiftUICore.framework/Versions/A/SwiftUICore.tbd': cannot link directly with 'SwiftUICore' because product being built is not an allowed client of it Undefined symbols for architecture arm64:
"_tree_sitter_css_external_scanner_create", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_deserialize", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_destroy", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_scan", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_css_external_scanner_serialize", referenced from:
_tree_sitter_css.language in TreeSitterCSS.o
"_tree_sitter_javascript_external_scanner_create", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_deserialize", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_destroy", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_scan", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
"_tree_sitter_javascript_external_scanner_serialize", referenced from:
_tree_sitter_javascript.language in TreeSitterJavaScript.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)