Select2 4.0.0, ngHandsontable 0.7.0-beta1 and Handsontable 0.19 support#16
Open
motin wants to merge 15 commits into
Open
Conversation
Contributor
Author
|
Any chance this can be merged anytime soon? |
…luntary due to angular magic, for instance by using ngHandsontable)
…ade by pressing the enter key
…e it causes a js error with select2 4.0
motin
force-pushed
the
handsontable-0.17-ngHandsontable-0.7.0-select2-4.0.0-support
branch
from
e6ff3e2 to
e52157d
Compare
Contributor
Author
|
@trebuchetty Rebased the files on latest master and verified that it works with Handsontable 0.19 |
motin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Not backwards-compatible with 3.5.2 due to changed select2 api.
Includes the commits from #12 and #13