Improve ROI Reporting Agent setup documentation and file organization#436
Merged
toru-takahashi merged 1 commit intoApr 17, 2026
Merged
Conversation
This commit improves the user experience for setting up the ROI Reporting Agent by: ## File Organization - Move Japanese reference materials to docs/japanese/ directory - OverallSummary_Spec_ja.md - CampaignDetails_Spec_ja.md - prompt_ja.md - README_JA.md - Prevents accidental deployment of unused Japanese Text KBs (reduces from 4 to 2 Text KBs) - Keeps Japanese materials accessible for reference ## README Improvements ### Setup Instructions - Add explicit database creation step - Clarify that default project name "ROI Reporting Agent" works out-of-box - Move custom project name to "Advanced Options" section - Add verification steps with expected output - Use collapsible sections for optional configurations ### File Structure - Update to reflect new docs/japanese/ structure - Add notes about auto-generated files - Clarify language-independent report generation ### Troubleshooting - Expand from table to detailed sections - Add solutions for common setup issues: - LLM_PROJECT_NOT_FOUND - Database not found - Missing tools/outputs - tdx version issues - Add usage troubleshooting (Japanese reports, parameters, etc.) - Include project management guidance ### Japanese Documentation - Add new section explaining docs/japanese/ contents - Clarify that English KBs work for both languages - Provide advanced option to use Japanese specs ## Expected Impact - Reduces user confusion during setup (2 Text KBs instead of 4) - Makes default setup work immediately without customization - Provides clear troubleshooting guidance - Maintains access to Japanese reference materials Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes Japanese reference materials for the ROI Reporting Agent into docs/japanese/ and expands the main setup README to make first-time deployment and troubleshooting clearer.
Changes:
- Moved Japanese prompt/spec/README reference files under
agent/docs/japanese/to avoid accidental deployment as extra Text KBs. - Expanded
agent/README.mdwith clearer setup steps (including DB creation), deployment verification, advanced options, and detailed troubleshooting. - Added Japanese reference documentation files in their new location.
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| engage-box/roi_reporting/agent/README.md | Improves setup flow, verification steps, troubleshooting, and documents the new docs/japanese/ layout (includes a broken link to workflow docs). |
| engage-box/roi_reporting/agent/docs/japanese/README_JA.md | Adds Japanese README, but currently still describes the old (pre-reorg) file layout and tdx.json example. |
| engage-box/roi_reporting/agent/docs/japanese/prompt_ja.md | Adds Japanese system prompt reference under docs/japanese/. |
| engage-box/roi_reporting/agent/docs/japanese/OverallSummary_Spec_ja.md | Adds Japanese OverallSummary spec reference, but the link to the English spec is now broken due to relocation. |
| engage-box/roi_reporting/agent/docs/japanese/CampaignDetails_Spec_ja.md | Adds Japanese CampaignDetails spec reference, but the link to the English spec is now broken due to relocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toru-takahashi
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the ROI Reporting Agent setup experience by reorganizing Japanese reference files and enhancing documentation.
Changes
📁 File Organization
docs/japanese/OverallSummary_Spec_ja.mdCampaignDetails_Spec_ja.mdprompt_ja.mdREADME_JA.md📖 README Improvements
Setup Instructions
File Structure
docs/japanese/structureTroubleshooting
Japanese Documentation (New Section)
docs/japanese/contentsTesting
Verified with fresh clone from GitHub:
Result:
Expected Impact
User Experience
Maintenance
docs/japanese/)Checklist
Related
This addresses user feedback about setup complexity and confusion regarding Japanese KB files.