Skip to content

Improve ROI Reporting Agent setup documentation and file organization#436

Merged
toru-takahashi merged 1 commit into
treasure-data:masterfrom
ko47kmr:improve-roi-agent-setup-docs
Apr 17, 2026
Merged

Improve ROI Reporting Agent setup documentation and file organization#436
toru-takahashi merged 1 commit into
treasure-data:masterfrom
ko47kmr:improve-roi-agent-setup-docs

Conversation

@ko47kmr

@ko47kmr ko47kmr commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR improves the ROI Reporting Agent setup experience by reorganizing Japanese reference files and enhancing documentation.

Changes

📁 File Organization

  • Move Japanese files to docs/japanese/
    • OverallSummary_Spec_ja.md
    • CampaignDetails_Spec_ja.md
    • prompt_ja.md
    • README_JA.md
  • Impact: Reduces Text KBs created from 4 to 2 (prevents accidental deployment of unused Japanese KBs)
  • Benefit: Simpler, clearer setup while keeping Japanese materials accessible for reference

📖 README Improvements

Setup Instructions

  • ✅ Add explicit database creation step with error handling note
  • ✅ Clarify default project name works out-of-box
  • ✅ Move custom project name to "Advanced Options" (collapsible section)
  • ✅ Add verification steps with expected output
  • ✅ Organize optional configurations in collapsible sections

File Structure

  • ✅ Update to reflect new docs/japanese/ structure
  • ✅ Add notes about auto-generated files
  • ✅ Clarify language-independent report generation

Troubleshooting

  • ✅ Expand from simple table to detailed sections with solutions
  • ✅ Add setup issue solutions:
    • LLM_PROJECT_NOT_FOUND
    • Database not found
    • Missing tools/outputs
    • tdx version issues
  • ✅ Add usage troubleshooting (Japanese reports, missing parameters, etc.)
  • ✅ Include project management guidance

Japanese Documentation (New Section)

  • ✅ Explain docs/japanese/ contents
  • ✅ Clarify English KBs work for both languages
  • ✅ Provide advanced option to use Japanese specs

Testing

Verified with fresh clone from GitHub:

cd /tmp
git clone --depth 1 --filter=blob:none --sparse https://github.com/treasure-data/treasure-boxes.git test-agent
cd test-agent
git sparse-checkout set engage-box/roi_reporting
cd engage-box/roi_reporting/agent

tdx llm project create "Test ROI Agent"
tdx agent push . -f

Result:

  • ✅ Text Knowledge Bases: 2 created (previously 4)
  • ✅ Agent tools: 4/4 correctly configured
  • ✅ All components deployed successfully

Expected Impact

User Experience

  • ✅ Default setup works immediately (no customization needed)
  • ✅ Less confusion (2 Text KBs vs 4)
  • ✅ Clear troubleshooting when issues arise
  • ✅ Japanese materials still accessible for reference

Maintenance

  • ✅ Clearer file organization
  • ✅ Self-documenting structure (docs/japanese/)
  • ✅ No breaking changes (English setup unchanged)

Checklist

  • File organization changes implemented
  • README sections updated
  • Tested with fresh repository clone
  • Verified Text KB count reduced to 2
  • Confirmed all agent tools/outputs work
  • Japanese materials accessible in docs/

Related

This addresses user feedback about setup complexity and confusion regarding Japanese KB files.

This commit improves the user experience for setting up the ROI Reporting Agent by:

## File Organization
- Move Japanese reference materials to docs/japanese/ directory
  - OverallSummary_Spec_ja.md
  - CampaignDetails_Spec_ja.md
  - prompt_ja.md
  - README_JA.md
- Prevents accidental deployment of unused Japanese Text KBs (reduces from 4 to 2 Text KBs)
- Keeps Japanese materials accessible for reference

## README Improvements

### Setup Instructions
- Add explicit database creation step
- Clarify that default project name "ROI Reporting Agent" works out-of-box
- Move custom project name to "Advanced Options" section
- Add verification steps with expected output
- Use collapsible sections for optional configurations

### File Structure
- Update to reflect new docs/japanese/ structure
- Add notes about auto-generated files
- Clarify language-independent report generation

### Troubleshooting
- Expand from table to detailed sections
- Add solutions for common setup issues:
  - LLM_PROJECT_NOT_FOUND
  - Database not found
  - Missing tools/outputs
  - tdx version issues
- Add usage troubleshooting (Japanese reports, parameters, etc.)
- Include project management guidance

### Japanese Documentation
- Add new section explaining docs/japanese/ contents
- Clarify that English KBs work for both languages
- Provide advanced option to use Japanese specs

## Expected Impact
- Reduces user confusion during setup (2 Text KBs instead of 4)
- Makes default setup work immediately without customization
- Provides clear troubleshooting guidance
- Maintains access to Japanese reference materials

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@ko47kmr ko47kmr requested a review from a team as a code owner April 14, 2026 02:59
Copilot AI review requested due to automatic review settings April 14, 2026 02:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes Japanese reference materials for the ROI Reporting Agent into docs/japanese/ and expands the main setup README to make first-time deployment and troubleshooting clearer.

Changes:

  • Moved Japanese prompt/spec/README reference files under agent/docs/japanese/ to avoid accidental deployment as extra Text KBs.
  • Expanded agent/README.md with clearer setup steps (including DB creation), deployment verification, advanced options, and detailed troubleshooting.
  • Added Japanese reference documentation files in their new location.

Reviewed changes

Copilot reviewed 1 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
engage-box/roi_reporting/agent/README.md Improves setup flow, verification steps, troubleshooting, and documents the new docs/japanese/ layout (includes a broken link to workflow docs).
engage-box/roi_reporting/agent/docs/japanese/README_JA.md Adds Japanese README, but currently still describes the old (pre-reorg) file layout and tdx.json example.
engage-box/roi_reporting/agent/docs/japanese/prompt_ja.md Adds Japanese system prompt reference under docs/japanese/.
engage-box/roi_reporting/agent/docs/japanese/OverallSummary_Spec_ja.md Adds Japanese OverallSummary spec reference, but the link to the English spec is now broken due to relocation.
engage-box/roi_reporting/agent/docs/japanese/CampaignDetails_Spec_ja.md Adds Japanese CampaignDetails spec reference, but the link to the English spec is now broken due to relocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread engage-box/roi_reporting/agent/README.md
@toru-takahashi toru-takahashi merged commit 888552a into treasure-data:master Apr 17, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants