Test coverage 40% + several fixes#21
Open
dvp2015 wants to merge 54 commits into
Open
Conversation
added 30 commits
April 19, 2026 00:12
- Stop support of Python2 in favor of new libraries - Stop using deprecates setup.* files - Add style checks - Workaroun on missed branch in ancient splitter module
... this is extremly low for production quality package will be increased with time
use commmands: just docs - for auto serving the docs page just docs-build - to build the docs
and remove obsolete files
added 24 commits
April 21, 2026 23:45
made xfail: need low level testing of parser module
made xfail: need low level testing of parser module
this method only relates to Card class, which is not defined in parser module. And this is the only used method from numbering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly the code research based on unit testing. The fixes in the code were applied only in cases where it was absolutely obvious and necessary to move further. When in doubt, I've just xfailed the tests showing errors.
Ruff formatting was applied only for edited files: I decided keep default 'ruff' formatting settings and don't try to reproduce the original style. That caused replacement of single quotes to double ones, and git diffs are somewhat polluted with formatting changes. Anyway, the default 'ruff' style is going to be standard. Before further code changes the formatting style is to be defined.