Limit size of incoming requests#814
Merged
phbnf merged 3 commits intotransparency-dev:mainfrom Mar 27, 2026
Merged
Conversation
AlCutter
approved these changes
Mar 26, 2026
cmd/tesseract/aws/main.go
Outdated
| Addr: *httpEndpoint, | ||
| // Set timeout for reading headers to avoid a slowloris attack. | ||
| ReadHeaderTimeout: 5 * time.Second, | ||
| MaxHeaderBytes: 1 << 13, // 8 KiB |
Collaborator
There was a problem hiding this comment.
An easier-to-read representation of this might be 8<<10 (if you agree, could do the same for the flags too)
AlCutter
approved these changes
Mar 27, 2026
cmd/tesseract/gcp/main.go
Outdated
| // Performance flags | ||
| httpDeadline = flag.Duration("http_deadline", time.Second*10, "Deadline for HTTP requests.") | ||
| maxCertChainBytes = flag.Int64("max_cert_chain_bytes", 1<<19, "Maximum size of certificate chain in bytes for add-chain and add-pre-chain endpoints (default: 512 KiB)") | ||
| maxCertChainBytes = flag.Int64("max_cert_chain_bytes", 8<<16, "Maximum size of certificate chain in bytes for add-chain and add-pre-chain endpoints (default: 512 KiB)") |
Collaborator
There was a problem hiding this comment.
How about 512<<10?
(The thinking here is that it's easy for folks to recognise that <<10 is ~K, <<20 ~M, <<30 ~G, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits the size of POST requests to protect memory usage.