Skip to content

Add publishCheckpoint outcome attribute to traces#922

Merged
phbnf merged 1 commit intotransparency-dev:mainfrom
phbnf:trattr
Mar 27, 2026
Merged

Add publishCheckpoint outcome attribute to traces#922
phbnf merged 1 commit intotransparency-dev:mainfrom
phbnf:trattr

Conversation

@phbnf
Copy link
Copy Markdown
Contributor

@phbnf phbnf commented Mar 27, 2026

While I'm there:

  • rename error.type to tessera.publishCheckpoint.outcome
  • Make outcomeAttr an attribute.KeyValue instead of a slice of such
  • Introduce two new attribute values, success and aborted

This will:

  • provide a better attribute name since for instance "skipped" is not an error
  • avoid empty attributes, which are not very well supported by GCP (it shows a long hex string instead)
  • add the outcome to traces

@phbnf phbnf requested a review from a team as a code owner March 27, 2026 14:39
@phbnf phbnf requested review from AlCutter and roger2hk and removed request for roger2hk March 27, 2026 14:39
@phbnf
Copy link
Copy Markdown
Contributor Author

phbnf commented Mar 27, 2026

As per https://opentelemetry.io/docs/specs/semconv/general/recording-errors/#recording-errors-on-spans, we should set error.Type. However, we don't put it in other places where we use traces, so we should probably do a cleanup everywhere.

@phbnf phbnf merged commit dd26581 into transparency-dev:main Mar 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants