fix(sqlite): silence time 0.3.48 modifier deprecations under -D warnings#4311
Open
ricochet wants to merge 1 commit into
Open
fix(sqlite): silence time 0.3.48 modifier deprecations under -D warnings#4311ricochet wants to merge 1 commit into
ricochet wants to merge 1 commit into
Conversation
time 0.3.48 deprecated the field-based `modifier::{Year, Month, Hour}`
format components and raw-byte `Literal`, which broke `clippy -D warnings`
in CI (no Cargo.lock, so the latest `time` is resolved). The new
`#[non_exhaustive]` replacements aren't const-constructible the way these
`const` format items need, and the deprecated API still works, so scope an
`#![allow(deprecated)]` to `mod formats` as a stopgap.
Tracking for migration: transact-rs#4310
Signed-off-by: Bailey Hayes <bailey@cosmonic.com>
Contributor
Author
|
Going to close/re-open this pr to re-trigger workflow. Hit flake in https://github.com/transact-rs/sqlx/actions/runs/27626477394/job/81690173856?pr=4311: |
|
FYI, careful with your PR message as you'll accidentally close #4310. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
#![allow(deprecated)]for sqlite time formats to silence clippy warnings.time 0.3.48 deprecated the field-based
modifier::{Year, Month, Hour}format components and raw-byteLiteral, which brokeclippy -D warningsin CI (no Cargo.lock, so the latesttimeis resolved). The new#[non_exhaustive]replacements aren't const-constructible the way theseconstformat items need, and the deprecated API still works, so scope an tomod formatsas a stopgap.Does your PR solve an issue?
This is a stopgap for #4310. #4310 tracks performing a migration, while this change gets main CI back to passing.
Is this a breaking change?
No. To fully complete #4310, possibly but this PR does not cover that.