Skip to content

Sketch arc topology: single edge per arc, intersection splitting, tangent face walker#166

Merged
trailcode merged 7 commits into
mainfrom
Trailcode/sketch_topo_improve
Jul 6, 2026
Merged

Sketch arc topology: single edge per arc, intersection splitting, tangent face walker#166
trailcode merged 7 commits into
mainfrom
Trailcode/sketch_topo_improve

Conversation

@trailcode

@trailcode trailcode commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

  • Refactor sketch arcs to one graph edge per arc (replacing the prior two-edge internal model).
  • Split existing straight and arc edges when new lines or arcs cross them; subdivide new arcs at interior intersection points.
  • Face walking uses arc tangents at endpoints (fixes semicircle and slot-cap loops).
  • Arc Segment tool: straight rubber-band preview after the first click; Add midpoint nodes option (shared with line tools) adds a geometric-mid snap node when enabled.
  • User guide and changelog updated; open slot+circle intersection bug tracked in docs/bugs.md and Sketch: slot + circle edges split or highlight incorrectly at intersections #165.

Related

Test plan

  • Build and run EzyCad_tests (Debug)
  • Sketch_test.*Arc*, Sketch_test.UpdateFaces_SemicircleTangentWalker, Sketch_test.UpdateFaces_FaceWithArcs
  • Manual: Arc Segment three-click flow, rubber-band previews, optional midpoint node
  • Manual: line crossing arc splits both; slot + circle — confirm Sketch: slot + circle edges split or highlight incorrectly at intersections #165 still reproduces
  • sphinx-build -b html -W docs docs/_build

Made with Cursor

Trailcode and others added 6 commits July 5, 2026 16:56
Improve
777f264
Improve.
ee414e1
Arc midpoints option.
e4ae8b7
Bug fix.
4f86ff4
@cursoragent
Document arc topology in user guide and track slot+circle bug.
17ae81c 
Update usage-sketch for single-edge arcs, intersection splitting, previews,
and midpoint option; add bugs.md entry and agent drafts for issue/PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursoragent
Rename issue draft to gh-165 after filing on GitHub.
e2bfbd3 
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursoragent
Rename PR draft to gh-166 after opening pull request.
f0e2747 
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 5, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@trailcode trailcode merged commit a3ac307 into main Jul 6, 2026
3 checks passed
@trailcode trailcode deleted the Trailcode/sketch_topo_improve branch July 6, 2026 00:03
@trailcode trailcode mentioned this pull request Jul 6, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sketch: slot + circle edges split or highlight incorrectly at intersections

1 participant

@trailcode