Skip to content

feat: implement new cookie banner (via silktide CMP)#72

Merged
traefiker merged 2 commits into
traefik:mainfrom
Codalent:feat/improve-docs-ops
Mar 11, 2026
Merged

feat: implement new cookie banner (via silktide CMP)#72
traefiker merged 2 commits into
traefik:mainfrom
Codalent:feat/improve-docs-ops

Conversation

@arpban
Copy link
Copy Markdown

@arpban arpban commented Mar 3, 2026

Implemented a new Cookie banner on the docs using Silktide cookie banner. The cookie banner follows same design and functionality as on the main website.

Demo: https://drive.google.com/file/d/1N1lGgEuilGhtrUosYhlJsche0uFQwO2O/view?usp=sharing

@arpban arpban changed the title Improve docs website operations feat: implement new cookie banner (via silktide cmp) Mar 3, 2026
@arpban arpban changed the title feat: implement new cookie banner (via silktide cmp) feat: implement new cookie banner (via silktide CMP) Mar 3, 2026
@arpban arpban marked this pull request as ready for review March 3, 2026 16:20
Comment thread src/assets/stylesheets/cookie-banner.scss Outdated
Comment thread src/assets/stylesheets/cookie-banner.scss Outdated
@gndz07
Copy link
Copy Markdown
Member

gndz07 commented Mar 4, 2026

Side note, please run the linter to let the CI pass 🙂 (and to rerun the build before pushing).

Comment thread src/base.html
></script>
<script
defer
src="https://traefik.io/silktide-consent-manager/script.js"
Copy link
Copy Markdown
Member

@gndz07 gndz07 Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder about the fact that the script is fetched from a CDN, but the CSS is copied locally. If the remote source (the script) is updated, and it affects the styling, without us manually updating our copy of the CSS file it potentially will break the interface. Any reason why it's done this way?
I would prefer to have both of these resources come from the same source (either CDN or local copy) to avoid version mismatch. Other possibility, at the very least, if it's a must to have them from different sources, to be able to pin the version that is fetched from remote source.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the local CSS copy and now loading the styles from the CDN as well, so both the script and styles come from the same source and stay version-aligned.

@traefiker traefiker merged commit 8ce42fe into traefik:main Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants