feat: implement new cookie banner (via silktide CMP)#72
Conversation
|
Side note, please run the linter to let the CI pass 🙂 (and to rerun the build before pushing). |
| ></script> | ||
| <script | ||
| defer | ||
| src="https://traefik.io/silktide-consent-manager/script.js" |
There was a problem hiding this comment.
I wonder about the fact that the script is fetched from a CDN, but the CSS is copied locally. If the remote source (the script) is updated, and it affects the styling, without us manually updating our copy of the CSS file it potentially will break the interface. Any reason why it's done this way?
I would prefer to have both of these resources come from the same source (either CDN or local copy) to avoid version mismatch. Other possibility, at the very least, if it's a must to have them from different sources, to be able to pin the version that is fetched from remote source.
There was a problem hiding this comment.
Removed the local CSS copy and now loading the styles from the CDN as well, so both the script and styles come from the same source and stay version-aligned.
Implemented a new Cookie banner on the docs using Silktide cookie banner. The cookie banner follows same design and functionality as on the main website.
Demo: https://drive.google.com/file/d/1N1lGgEuilGhtrUosYhlJsche0uFQwO2O/view?usp=sharing