Adding Ensemble Model Functionality#10
Open
jacobmmears wants to merge 7 commits into
Open
Conversation
@doctype "package" is deprecated. ℹ Please document "_PACKAGE" instead.
Tried to match existing code syntax and associated documentation and verbiage.
|
@jacobmmears, did you create another repository for this project somewhere else? I am a research engineer, and I would like to upload the openmeteo R package to conda. |
Author
|
@Mathmath34 - I only forked it to my public personal repositories. I was planning on perhaps resurrecting or recreating it myself and submitting to CRAN, as I have emailed the creator (@tpisel) without any response. Edit: see here https://github.com/jacobmmears/openmeteo/tree/master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new function for the Ensemble Models endpoint. This is my first ever GitHub Pull Request, so please let me know if there is anything I can improve. I did try to replicate the package's original style and add/update all relevant documentation and tests. All checks passed with 0 errors, 0 warnings, 0 tests on my system. Thanks!