Make cache adapter configurable via application config #208
Open
daniikpando wants to merge 1 commit intotompave:masterfrom
Open
Make cache adapter configurable via application config #208daniikpando wants to merge 1 commit intotompave:masterfrom
daniikpando wants to merge 1 commit intotompave:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are cases where the current cache implementation doesn't cover all needs; for example, when you need custom logic within the cache layer, such as personalized logging, metrics, or key partitioning by umbrella apps (my case). Currently there's no way to swap the cache implementation without forking the library.
This change makes the cache adapter configurable so anyone can provide their implementation while keeping the default ETS-based cache.
No breaking changes
This is fully compatible. When no adapter is configured, the library defaults to the existing
FunWithFlags.Store.Cache, so current users are not affected in any way.Usage
To use a custom cache, simply implement the
FunWithFlags.Store.Cache.Behaviourand configure it: