Skip to content

Fix three code bugs#1

Draft
tomerazran wants to merge 1 commit into
masterfrom
cursor/fix-three-code-bugs-9a75
Draft

Fix three code bugs#1
tomerazran wants to merge 1 commit into
masterfrom
cursor/fix-three-code-bugs-9a75

Conversation

@tomerazran

Copy link
Copy Markdown
Owner

Fixes multiple bugs related to exception handling, type checking logic, error robustness, and code clarity.

This PR addresses four specific issues:

  1. Replaces NotImplemented() with NotImplementedError() in cache.py for proper exception raising.
  2. Corrects type checking order in helpers.py (bool before int, datetime before date) to prevent incorrect type identification.
  3. Adds a check for empty port dictionaries in client.py to prevent IndexError.
  4. Adds an explicit return None in cache.py when data decoding fails, improving code clarity.

Open in Cursor Open in Web

Learn more about Cursor Agents

Co-authored-by: tomerazran <tomerazran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants