Update 0x10450-shavian.json#23
Open
jdonland wants to merge 1 commit intotomer:masterfrom
jdonland:patch-1
Open
Update 0x10450-shavian.json#23jdonland wants to merge 1 commit intotomer:masterfrom jdonland:patch-1
jdonland wants to merge 1 commit intotomer:masterfrom
jdonland:patch-1
Conversation
Correct two miscategorizations, change categories to better reflect usual sort of Shavian letters.
Owner
|
These files are auto-generated, so unless there is a problem on the generation code, I afraid there is no option to fix. Have you compared the data available here with the Unicode tables? |
Author
|
Unicode doesn't distinguish between categories of Shavian letters
(consonant vs vowel or anything else). You have ROAR and NUN categorized as
vowels but they are consonants. And in any case it is more useful to
categorize Shavian letters as tall/deep, short, and ligature rather than
consonant and vowel. Something has gone wrong in whatever generates your
categories.
…On Sat, 20 Jan 2018 at 19:31 Tomer Cohen ***@***.***> wrote:
These files are auto-generated, so unless there is a problem on the
generation code, I afraid there is no option to fix. Have you compared the
data available here with the Unicode tables?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMvRmbYxZ7VTWrXklL96Y-CU3s0KClSrks5tMoVcgaJpZM4RlpEw>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct two miscategorizations, change categories to better reflect usual sort of Shavian letters.