Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new in-app “Config” tab intended to let users configure the server endpoint (IP/port), and updates the foreground service to run the local sensor server on a configurable port read from SharedPreferences.
Changes:
- Added new Config page UI with inputs for “Server IP” and “Server port”, plus persistence/validation via SharedPreferences.
- Updated
SensorServerServiceto use a configurable port (and restart the server when the port changes), including updating the notification text. - Updated status/endpoint text and ADB forwarding instructions to reflect the current configured/running port.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds Config-related UI strings and validation/toast messages. |
| app/src/main/java/com/example/androidexposed/SensorServerService.java | Replaces fixed port constant with a configurable port and restarts server on port change; updates notification text. |
| app/src/main/java/com/example/androidexposed/MainActivity.java | Adds Config tab/page UI, persists endpoint settings, and updates displayed port/endpoint instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+9
| <string name="server_port">Server port</string> | ||
| <string name="save_config">Save</string> | ||
| <string name="current_config">Current server: %1$s:%2$d</string> | ||
| <string name="server_ip_required">Server IP is required</string> | ||
| <string name="server_port_required">Server port is required</string> |
Comment on lines
+272
to
+275
| private int getConfiguredPort() { | ||
| return getSharedPreferences(MainActivity.PREFS_NAME, MODE_PRIVATE) | ||
| .getInt(MainActivity.KEY_SERVER_PORT, DEFAULT_PORT); | ||
| } |
Comment on lines
+766
to
+769
| private String endpointText() { | ||
| int port = currentServerPort(); | ||
| return "Endpoint: http://127.0.0.1:" + port + "\nUse: adb forward tcp:" + port + " tcp:" + port; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.