Skip to content

Report the correct fields when they are invalid in the vote and register API actions #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynn merged 2 commits into from
Apr 15, 2026
Merged

Report the correct fields when they are invalid in the vote and register API actions #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76cf353
fix(vote): report the correct field when vote is invalid
Lilith-In-Starlight Apr 8, 2026
eec762b
fix(register): report
Lilith-In-Starlight Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export class Api {
const e_id = this.is_goodid(i.id);
if (e_id !== true) return flip(`invalid field 'id': ${e_id}`);
const e_vote = [-1, 0, 1].includes(i.vote) || 'invalid vote';
if (e_vote !== true) return flip(`invalid field 'id': ${e_id}`);
if (e_vote !== true) return flip(`invalid field 'vote': ${e_vote}`);

const e = this.by_id(i.id);
const old_vote = e.votes[uname] || 0;
Expand Down Expand Up @@ -375,7 +375,7 @@ export class Api {

public async register(i: any, uname: string): Promise<ApiResponse> {
if (!i.name.match(/^[a-zA-Z]{1,64}$/)) {
return flip(`invalid field 'id': name must be 1-64 Latin characters`);
return flip(`invalid field 'name': name must be 1-64 Latin characters`);
}
const e_pass = limit(128)(i.pass);
if (e_pass !== true) return flip(`invalid field 'pass': ${e_pass}`);
Expand Down
Loading