Move the call to strlen outside the for loop comparison#41
Open
mingodad wants to merge 2 commits intotmikolov:masterfrom
Open
Move the call to strlen outside the for loop comparison#41mingodad wants to merge 2 commits intotmikolov:masterfrom
mingodad wants to merge 2 commits intotmikolov:masterfrom
Conversation
It's not necessary to recalculate the "strlen(word)" on every loop comparison when "word" doesn't change inside the loop.
Here also the same code as in word2vec.c
ccreutzig
reviewed
Nov 6, 2018
ccreutzig
left a comment
ccreutzig
left a comment
There was a problem hiding this comment.
The compiler knows that, too, and will move the strlen call out of the loop: https://gcc.godbolt.org/z/Pnso2q
Making the change explicit is not necessarily a bad idea; but then, I would suggest having const unsigned long long str_len=strlen(word); in a line of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not necessary to recalculate the "strlen(word)" on every loop comparison when "word" doesn't change inside the loop.