Merged
Conversation
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
damiendoligez
approved these changes
Dec 18, 2025
Contributor
damiendoligez
left a comment
damiendoligez
left a comment
There was a problem hiding this comment.
Looks good.
I don't know why you have many functions with type annotations for the arguments and results (at first glance I would say the compiler can infer most of them) but it doesn't really hurt.
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Collaborator
Author
|
The type annotations are a habit from rust/java I suppose. I like type annotations! Sometimes they also make error messages easier to understand. Yeah they make things verbose though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to facilitate merge of PR #177 and form test base for any further command line modifications.
Tried to minimize changes to actual code; mostly required injecting
Format.formatterinstances to capture output and also trapping calls toexit.