Skip to content

Add 'removeNoteWithConfirmation' command and associate with 'remove' UI#12

Open
canadaduane wants to merge 1 commit into
tkrkt:masterfrom
canadaduane:confirm-before-remove
Open

Add 'removeNoteWithConfirmation' command and associate with 'remove' UI#12
canadaduane wants to merge 1 commit into
tkrkt:masterfrom
canadaduane:confirm-before-remove

Conversation

@canadaduane
Copy link
Copy Markdown

Fixes #8

Comment thread src/extension.ts
decorateDebounce();
}
const confirmed = await vscode.window
.showInformationMessage(`Are you sure you'd like to permanently remove this note?`,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with translation files... maybe add a translation for this? How?

Comment thread src/extension.ts
}
const confirmed = await vscode.window
.showInformationMessage(`Are you sure you'd like to permanently remove this note?`,
...['Yes', 'No']) === 'Yes';
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for Yes/No, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirm on delete

1 participant