Skip to content

Check if withdraw value is positive #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RedstoneFX wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Check if withdraw value is positive #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a15e95
Update PlaceholderAPI dependency (old is no longer avaliable)
RedstoneFX Jul 30, 2025
f67ab4c
Check withdraw value to be positive
RedstoneFX Jul 30, 2025
c2093a1
Prevent function from execution if withdraw amout is negative
RedstoneFX Jul 30, 2025
25d6061
Language support for tax witdraw value check
RedstoneFX Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
<dependency>
<groupId>me.clip</groupId>
<artifactId>placeholderapi</artifactId>
<version>2.10.10</version>
<version>2.11.5</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/tk/taverncraft/quicktax/commands/WithdrawCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ public boolean withdrawForSelf(CommandSender sender, String strAmount) {

double amount = Double.parseDouble(strAmount);

if(amount <= 0) {
MessageManager.sendMessage(sender,"tax-withdraw-fail-invalid");
return false;
}

try {
double totalTaxBalance = Double.parseDouble(this.main.getStatsManager().getServerStats()[1]);
if (validationManager.serverHasTaxBalance(amount, totalTaxBalance)) {
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ tax-collect-success-bal: '&aTaxes collected for players by balance!'
tax-collect-success-activity: '&aTaxes collected for players by activity!'
tax-withdraw-success: '&aBalance withdrawn successfully!'
tax-withdraw-fail: '&cThere is insufficient server tax balance!'
tax-withdraw-fail-invalid: '&cCannot withdraw negative or zero current from balance!'
tax-collect-fail-individual: '&b%player% &chas no money to pay tax!' # %player%
tax-collect-already-running: '&cAn existing tax collection is ongoing, please try again later!'
tax-exempt: '&cThe player &b%player% &cis exempted from your tax collection!'
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ tax-collect-success-rank: '&a¡Impuestos Recaudados de todos los jugadores por r
tax-collect-success-bal: '¡Impuestos Recaudados de todos los jugadores por dinero!'
tax-withdraw-success: '&aFondos retirados de la cuenta del Servidor!'
tax-withdraw-fail: '&cFondos insuficientes. La cuenta del Servidor no tiene ese saldo de impuestos para retirar!'
tax-withdraw-fail-invalid: '&cNo puede retirar corriente negativa o cero del saldo!'
tax-collect-fail-individual: '&b%player% &cno tiene dinero para pagar sus impuestos!' # %player%
tax-collect-already-running: '&cHay una recaudación de impuestos en curso. Vuelva a intentarlo más tarde!'
player-pay-tax-fail: '&cTienes dinero insuficiente para pagar tus impuestos!' # %player%
Expand Down