Skip to content

fix(bazel): use module-scoped npm extension repo#2

Merged
Jess Sullivan (Jesssullivan) merged 1 commit into
mainfrom
jess/fix-unique-npm-extension-repo
Apr 27, 2026
Merged

fix(bazel): use module-scoped npm extension repo#2
Jess Sullivan (Jesssullivan) merged 1 commit into
mainfrom
jess/fix-unique-npm-extension-repo

Conversation

@Jesssullivan

Copy link
Copy Markdown
Contributor

Summary

  • rename the generated npm extension repo from generic npm to tummycrypt_tinyland_user_resolution_npm
  • update BUILD.bazel loads to use the module-scoped npm repo
  • prepare the module for composition in the active Bazel registry

Validation

  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm check:package
  • npx --yes @bazel/bazelisk build //:pkg //:test --verbose_failures

@greptile-apps

greptile-apps Bot commented Apr 27, 2026

Copy link
Copy Markdown

Greptile Summary

This PR renames the npm extension repo from the generic npm to the module-scoped tummycrypt_tinyland_user_resolution_npm in both MODULE.bazel and BUILD.bazel, and updates all load() references accordingly. The change is the correct approach for Bzlmod-based registry composition, preventing name collisions when this module is consumed alongside others that also declare an npm extension repo.

Confidence Score: 5/5

This PR is safe to merge — it is a clean, consistent rename with no stale references remaining.

Both changed files are updated symmetrically, no old @npm// references remain anywhere in the repo, and the rename follows the correct Bzlmod module-scoping convention for registry composition.

No files require special attention.

Important Files Changed

Filename Overview
MODULE.bazel Renames npm_translate_lock name and corresponding use_repo call from npm to tummycrypt_tinyland_user_resolution_npm — correct Bzlmod scoping practice.
BUILD.bazel Updates both load() references from @npm// to @tummycrypt_tinyland_user_resolution_npm//, consistently matching the MODULE.bazel rename with no stale references remaining.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["MODULE.bazel\nnpm.npm_translate_lock(name = 'tummycrypt_tinyland_user_resolution_npm')"] --> B["use_repo(npm, 'tummycrypt_tinyland_user_resolution_npm')"]
    B --> C["Bzlmod registry\nmodule-scoped repo: @tummycrypt_tinyland_user_resolution_npm//"]
    C --> D["BUILD.bazel\nload('@tummycrypt_tinyland_user_resolution_npm//:defs.bzl', ...)"]
    C --> E["BUILD.bazel\nload('@tummycrypt_tinyland_user_resolution_npm//:vitest/package_json.bzl', ...)"]
Loading

Reviews (1): Last reviewed commit: "fix(bazel): use module-scoped npm extens..." | Re-trigger Greptile

@Jesssullivan Jess Sullivan (Jesssullivan) merged commit edd71bf into main Apr 27, 2026
5 checks passed
@Jesssullivan Jess Sullivan (Jesssullivan) deleted the jess/fix-unique-npm-extension-repo branch April 27, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant