fix(ci): align publish workflow package scope#8
Conversation
Greptile SummaryThis PR updates the publish workflow to use a newer ci-templates SHA, renames the GitHub Packages scope from Confidence Score: 4/5Safe to merge with awareness that downstream consumers of the old @tummycrypt scope will not receive further updates. Only P2 findings: broader secrets surface via .github/workflows/publish.yml — confirm ci-templates at new SHA does not forward secrets to third-party steps, and communicate the scope rename to downstream consumers.
|
| Filename | Overview |
|---|---|
| .github/workflows/publish.yml | Updated reusable workflow SHA, renamed package scope from @tummycrypt to Tinyland, Inc (@tinyland-inc), and switched from explicit NPM_TOKEN secret mapping to secrets: inherit — all intentional, with minor breadth concern on secrets and a breaking change for existing consumers of the old scope. |
Sequence Diagram
sequenceDiagram
participant GH as GitHub Event (release / workflow_dispatch)
participant PW as publish.yml
participant CT as ci-templates js-bazel-package.yml@0d88ad7
participant GPR as GitHub Packages
GH->>PW: Trigger (release published or manual)
PW->>CT: uses reusable workflow with github_package_name=@tinyland-inc/tinyland-security
Note over PW,CT: secrets: inherit (all repo secrets forwarded)
CT->>CT: Build (pnpm build / bazel)
CT->>CT: Test (pnpm test)
CT->>CT: Package check
CT->>GPR: Publish @tinyland-inc/tinyland-security (unless dry_run=true)
Reviews (1): Last reviewed commit: "fix(ci): align publish workflow package ..." | Re-trigger Greptile
| dry_run: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || false }} | ||
| secrets: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| secrets: inherit |
There was a problem hiding this comment.
secrets: inherit passes all repository secrets
Switching from an explicit NPM_TOKEN: ${{ secrets.NPM_TOKEN }} mapping to secrets: inherit causes the reusable workflow to receive every secret in this repository's context (tokens, credentials, keys), not just NPM_TOKEN. If any future secret added to this repo is sensitive and the reusable workflow (or a step it delegates to) logs or forwards it unexpectedly, the blast radius is larger than before. This is acceptable when the callee is a fully-trusted, pinned workflow within the same org — just worth confirming that tinyland-inc/ci-templates at this SHA does not fan out secrets to third-party steps.
| package_dir: ./bazel-bin/pkg | ||
| npm_access: public | ||
| github_package_name: "@tummycrypt/tinyland-security" | ||
| github_package_name: "@tinyland-inc/tinyland-security" |
There was a problem hiding this comment.
Package scope rename is a breaking change for existing consumers
Renaming github_package_name from @tummycrypt/tinyland-security to @tinyland-inc/tinyland-security means the next publish will create a brand-new package entry in GitHub Packages under the @tinyland-inc scope. Any downstream project currently depending on @tummycrypt/tinyland-security will silently stop receiving updates unless its package.json is updated. Consider publishing a final deprecation notice or stub release under the old scope pointing users to the new name.
Summary
Validation