Adding try/catch block to avoid fatal error in case of missing langua…#229
Open
ralphbuijtendorp wants to merge 1 commit intotimvisee:masterfrom
Open
Adding try/catch block to avoid fatal error in case of missing langua…#229ralphbuijtendorp wants to merge 1 commit intotimvisee:masterfrom
ralphbuijtendorp wants to merge 1 commit intotimvisee:masterfrom
Conversation
Author
|
I've made some translation changes and didn't want to apply this to all the .tfl files to keep it maintainable. After I deleted the .tfl files I found out that the app isn't handling missing language files correctly. This is the fix for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a try/catch block in case that Node wants to use none-existing tfl files.
@timvisee , Hi, any time yet to look at this? :)