Support downloading multiple files#169
Open
YDX-2147483647 wants to merge 2 commits intotimvisee:masterfrom
Open
Support downloading multiple files#169YDX-2147483647 wants to merge 2 commits intotimvisee:masterfrom
YDX-2147483647 wants to merge 2 commits intotimvisee:masterfrom
Conversation
YDX-2147483647
added a commit
to YDX-2147483647/ffsend-api
that referenced
this pull request
Sep 29, 2023
0803b25 to
c06bec2
Compare
timvisee
pushed a commit
to timvisee/ffsend-api
that referenced
this pull request
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading multiple files, Send concatenates all files into a raw stream. This PR checks the files manifest, and split the stream back to normal files.
Technical details
Research about the sever side
#134 (comment)
Implementation
If we are downloading multiple files (
if metadata.mime() == "send-archive"):fn split(archive: File, files: Vec<ManifestFile>))Other changes
Replace
extract: boolwithenum InvokeStrategyReplace
file: boolofprepare_path()withstrategy: &InvokeStrategyExpose manifest and its files from metadata API: Expose manifest and its files from metadata API (to support downloading multiple files) ffsend-api#82
SplitError, itsFromtrait, etc.Additional information
Resolves #134
Please merge timvisee/ffsend-api#82 first if you want to merge this PR.