Open
Conversation
Fixes #169 The regex pattern for detecting album art files has been expanded to include common filename variations that were previously not recognized: - albumart.jpg/png (iTunes/Windows Media Player standard) - front.jpg/png (front cover artwork) - artwork.jpg/png (generic artwork files) These additions complement the existing patterns (folder, cover, album) and maintain support for hidden files (those starting with a dot). The pattern now matches: - folder.jpg, cover.jpg, album.jpg (existing) - albumart.jpg, albumartsmall.jpg (new) - front.jpg, frontcover.jpg (new) - artwork.jpg (new) - All with optional leading dot for hidden files
Contributor
|
I had a look to the changes the other day and saw some room for improvement, so I've gone ahead and done some improvements:
I've pushed the changes to the branch alexm-improve-artowork-detection (rebased to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169
The regex pattern for detecting album art files has been expanded to include common filename variations that were previously not recognized:
These additions complement the existing patterns (folder, cover, album) and maintain support for hidden files (those starting with a dot).
The pattern now matches: