Conversation
This will be useful when exporting update playlists to their original path
Owner
|
I need to review this one. My only concern is we accidentally mess up m3u files, so like you say - it would be good to have an option to opt-in or out. I'll try to find some time to have a closer look. We can always roll it out and then add opt-in/out later. |
Contributor
Author
It's up to you to choose here. I just have to warn that I don't have the skills in Android development to do this myself 😢 (unless you give me precise hints at how to do UI updates and store user preferences somewhere) (I just pushed a new commit just so that the CI is now green) |
31ae8b3 to
8e3528f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @timusus
This MR resolves #112 .
I have been using this code for a while now, and it suits my needs.
What it does
When using an S2 Media Store, when adding or removing or reordering songs to a playlist that initially came from an .m3u file on the disk, the underlying .m3u file gets updated on disk.
This way, the .m3u files are kept in sync with the Shuttle2 database.
What it doesn't do
deletePlaylistordeleteAllare called).renamePlaylistis called)Notes
I'd be happy to have your thoughts on this!