fix: ignore empty custom reasons #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

cnaples79 wants to merge 1 commit into timraay:main from cnaples79:fix-empty-other-reason

cnaples79 commented Dec 23, 2025 •

edited

Loading

Summary

strip empty/whitespace-only reasons from submissions so they are not treated as custom reasons
add a test covering empty and whitespace-only "Other" inputs

Rationale

avoid sending empty strings in reasons, which causes API errors for empty "Other..." fields (Fixes Submission error when sending empty "Other..." field #37)

Changes

add a reasons validator in ReportSubmissionData to drop empty entries
add unittest to ensure empty/whitespace reasons are removed and flags computed correctly

Test Plan

tests added for CI

Fixes #37


          fix: ignore empty custom reasons on submission

83d7af5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet