Handle more than one class in ClassApplier::addClass Method#312
Open
AdamMcCormick wants to merge 5 commits intotimdown:masterfrom
Open
Handle more than one class in ClassApplier::addClass Method#312AdamMcCormick wants to merge 5 commits intotimdown:masterfrom
AdamMcCormick wants to merge 5 commits intotimdown:masterfrom
Conversation
|
+1 for this feature request. Rangy used to support this in 1.3alpha.722 because it appended to an element's className property, whereas now classList is used. // old 1.3alpha.722 function
function addClass(el, cssClass) {
if (el.className) {
if (!hasClass(el, cssClass)) {
el.className += " " + cssClass;
}
} else {
el.className = cssClass;
}
} |
|
I am also in need of this functionality, would be awesome is this is merged in. |
|
I am using this workaround: |
|
A documented solution for adding an extra class is to use the But I wasn't able to get this method to work for more than one extra class since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attempting to use rangy to apply highlights and notes to a document reader application. While the library is really good at applying the highlights, I need to add several different classes to each highlight. I can't seem to find any means of doing that with the ClassApplier as-is. This change allows the caller to pass a space-separated list of classes to a ClassApplier and thereby add as many classes as needed.
My apologies if this isn't the right process to make such a suggestion.