Add support for (hopefully) upcoming CHL features#1
Open
DaloLorn wants to merge 10 commits into
Open
Conversation
This is *almost* the same setup I use for all my other mods (plus local builds of CHL/LWotC), but I've made a few adjustments to avoid breaking your existing workflow. Specifically, X2MBC will only expect the Highlander at `$env:X2EMPT_HIGHLANDER_FOLDER` if an extra switch is passed into the build script, and will otherwise behave as normal.
Added MCM localization and backend implementation for X2CommunityCore/X2WOTCCommunityHighlander#1540 (plus X2CommunityCore/X2WOTCCommunityHighlander#1542 due to relevance). TODO: - Implement MCM toggle for armor previews. (I'm not even checking Highlander configs right now!) - Improve code style (might not be a perfect fit for the EIR codebase yet). - Test in my local campaign. - Open Highlander PRs for this stuff already! - Keep this synced with any changes to the abovementioned Highlander PRs.
- Fixed the net mitigation calculator to correctly handle the data coming from AdjustArmorMitigation. - The armor modifier is now inserted below base weapon/ability damage. - Added some more trace logs left over from my debugging.
- Commented out all invocations of unreleased Highlander hooks. - Temporarily cloned CalculateMitigatedDamagePreview from my Highlander branch, to let it be used with the current live Highlander.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added MCM localization and backend implementation for X2CommunityCore/X2WOTCCommunityHighlander#1540 (plus X2CommunityCore/X2WOTCCommunityHighlander#1542 due to relevance).
Cannot be merged until the following Highlander PRs (plus a mandatory follow-up to make them compatible with each other) are merged and released:
TODO: