Add replication-group-secondary module for global datastore members#46
Merged
Conversation
The existing elasticache-redis/replication-group module always configures engine, engine_version, node_type, transit/at-rest encryption, parameter group, snapshots, and an auth token on aws_elasticache_replication_group. When a replication group joins a global datastore via global_replication_group_id, AWS inherits all of those from the primary and the provider's ConflictsWith rules reject them -- even when passed as null, because Terraform still sees the attribute as configured. The node_type=null path also crashed the alarm locals via replace(var.node_type, ...). This adds a dedicated replication-group-secondary module that omits every inherited/conflicting argument and exposes only what a secondary member needs (name, description, global_replication_group_id, subnets, replica count, security groups, alarms). The CloudWatch alarm node-type lookup now reads the node_type back off the created resource instead of a variable, and the random provider / auth-token generation are dropped since the token is inherited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing elasticache-redis/replication-group module always configures engine, engine_version, node_type, transit/at-rest encryption, parameter group, snapshots, and an auth token on aws_elasticache_replication_group. When a replication group joins a global datastore via global_replication_group_id, AWS inherits all of those from the primary and the provider's ConflictsWith rules reject them -- even when passed as null, because Terraform still sees the attribute as configured. The node_type=null path also crashed the alarm locals via replace(var.node_type, ...).
This adds a dedicated replication-group-secondary module that omits every inherited/conflicting argument and exposes only what a secondary member needs (name, description, global_replication_group_id, subnets, replica count, security groups, alarms). The CloudWatch alarm node-type lookup now reads the node_type back off the created resource instead of a variable, and the random provider / auth-token generation are dropped since the token is inherited.